[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a1776979fd8: [CodeGen][TLS] Set TLS Model for __tls_guard as well. (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https:

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 ___ cfe-commits mai

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser added a comment. @aaron.ballman thanks for the review. I have updated the patch. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2622 Guard->setThreadLocal(true); +Guard->setThreadLocalMode(CGM.GetDefaultLLVMTLSModel()); aaron.ballman wrote

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser updated this revision to Diff 270969. junparser marked an inline comment as done. junparser added a comment. address the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

aaron.ballman added a comment. Changes generally LGTM, but this is not my area of expertise. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2622 Guard->setThreadLocal(true); +Guard->setThreadLocalMode(CGM.GetDefaultLLVMTLSModel()); Do we need a simi

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser added a comment. @rnk @aaron.ballman any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser added a comment. kindly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

junparser created this revision. junparser added reviewers: chh, rnk, aaron.ballman, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. junparser edited the summary of this revision. For now we do not set tls model for tls_guard with/without option -ftls-model which