[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

rprichard added a comment. Ok, I'll run that command in the future, and I'll watch D80978 for updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/ https://reviews.llvm.org/D81622

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

MaskRay added a comment. Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c4ce202267e: [Driver] Search computed sysroot for libc++ header paths (authored by rprichard). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

danalbert accepted this revision. danalbert added a comment. In D81622#2094409 , @ldionne wrote: > While this doesn't look wrong to me -- and the correctness of this depends > entirely on where vendors decide to put their headers so it's hard for me to

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

ldionne added a comment. While this doesn't look wrong to me -- and the correctness of this depends entirely on where vendors decide to put their headers so it's hard for me to verify -- I'm wondering why not all toolchains use this mechanism. We seem to be adding an abstraction that's used

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks, Ryan! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/ https://reviews.llvm.org/D81622

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

rprichard updated this revision to Diff 270030. rprichard added a comment. Remove unnecessary `virtual` keyword. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/ https://reviews.llvm.org/D81622 Files:

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

srhines added a comment. Thanks, Ryan, for diagnosing and addressing this bug. Comment at: clang/lib/Driver/ToolChains/Linux.h:45 llvm::opt::ArgStringList ) const override; - virtual std::string computeSysRoot() const; + virtual std::string

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

rprichard added reviewers: srhines, danalbert, libc++, kristina. rprichard added a comment. FWIW, `computeSysRoot` is overridden by these toolchains: - Linux - MSP430ToolChain - MipsLLVMToolChain - RISCVToolChain I think this change restores the pre D69758

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

rprichard updated this revision to Diff 270009. rprichard added a comment. Reverse clang-format's change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/ https://reviews.llvm.org/D81622 Files: clang/include/clang/Driver/ToolChain.h

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

rprichard updated this revision to Diff 270005. rprichard added a comment. Rerun after installing clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81622/new/ https://reviews.llvm.org/D81622 Files:

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

rprichard created this revision. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb.