[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit on your behalf in 95a3550dc89a0d424d90e2c0ad30d9ecfa9422cf CHANGES SINCE LAST ACTION

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar added a comment. I do need someone to commit this, yes, thank you. I'm Jeff Trull edas...@att.net CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 ___ cfe-commits mailing list

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

aaron.ballman added a comment. In D81769#2109936 , @jaafar wrote: > One more simplification from Aaron. Thanks! No problem! Do you need someone to commit on your behalf, btw? If so, let me know what name and email address you would like me to

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar updated this revision to Diff 272813. jaafar marked an inline comment as done. jaafar added a comment. One more simplification from Aaron. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 Files:

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor nit, this LGTM Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:414-415 + for (const clang::Decl *D :

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:243 + if ((std::distance(ME->child_begin(), ME->child_end()) == 1) && + isa(*ME->children().begin())) { +// reference to data member without explicit "this"

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar updated this revision to Diff 272674. jaafar added a comment. Applied feedback from Nathan James CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar marked 3 inline comments as done. jaafar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:243 + if ((std::distance(ME->child_begin(), ME->child_end()) == 1) && + isa(*ME->children().begin())) { +// reference to data

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar updated this revision to Diff 272580. jaafar added a comment. Applied feedback from Aaron Ballman. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar marked an inline comment as done. jaafar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:243 + if ((std::distance(ME->child_begin(), ME->child_end()) == 1) && + isa(*ME->children().begin())) { +// reference to data

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

aaron.ballman added a comment. In D81769#2106574 , @jaafar wrote: > "Ping". I hope this can be considered for 10.0.1. If nothing else I think > reviewing the test cases has a lot of value - there are some real issues with > the current checks and

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar added a comment. "Ping". I hope this can be considered for 10.0.1. If nothing else I think reviewing the test cases has a lot of value - there are some real issues with the current checks and fixits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION