[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

2020-06-15 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. In D81845#2093056 , @sammccall wrote: > May have broken tests: > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/30458/steps/test-check-all/logs/FAIL%3A%20Clangd%3A%3A%20type-hierarchy.test Sorry about that,

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

2020-06-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. May have broken tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/30458/steps/test-check-all/logs/FAIL%3A%20Clangd%3A%3A%20type-hierarchy.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

2020-06-15 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7759f70fb0ee: [clangd] Support typeHierarchy/resolve for children of parents as well (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

2020-06-15 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 270769. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81845/new/ https://reviews.llvm.org/D81845 Files: clang-tools-extra/clangd/XRefs.cpp Index:

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

2020-06-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:1233 + llvm::SmallString<32> USR; + if (!index::generateUSRForDecl(, USR)) { +THI.data = SymbolID(USR).str();

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

2020-06-15 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.