This revision was automatically updated to reflect the committed changes.
Closed by commit rGed1b556954eb: [NFC] Cleanup of EmitCXXGlobalInitFunc() and
EmitCXXGlobalDtorFunc() (authored by Xiangling_L).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
LGTM; thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81972/new/
https://reviews.llvm.org/D81972
___
cfe-commits mailing list
Xiangling_L updated this revision to Diff 271661.
Xiangling_L marked 2 inline comments as done.
Xiangling_L added a comment.
Address comments;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81972/new/
https://reviews.llvm.org/D81972
Files:
clang/lib/CodeGen/CGDeclCXX.cpp
Index:
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:600
+ // with priority emitted above.
+ SmallString<128> FileName;
llvm::Function *Fn = CreateGlobalInitOrDestructFunction(
In the less complex context of this patch,
jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596
}
+ // Include the filename in the symbol name. Including "sub_" matches gcc
Xiangling_L
Xiangling_L updated this revision to Diff 271492.
Xiangling_L added a comment.
Add the context to the patch;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81972/new/
https://reviews.llvm.org/D81972
Files:
clang/lib/CodeGen/CGDeclCXX.cpp
Index: clang/lib/CodeGen/CGDeclCXX.cpp
jasonliu added a comment.
New diff does not have context available.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81972/new/
https://reviews.llvm.org/D81972
___
cfe-commits mailing list
Xiangling_L added inline comments.
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596
}
+ // Include the filename in the symbol name. Including "sub_" matches gcc
jasonliu wrote:
> jasonliu wrote:
> > jasonliu wrote:
> > > I think this patch is missing what
Xiangling_L updated this revision to Diff 271486.
Xiangling_L marked 3 inline comments as done.
Xiangling_L added a comment.
Remove early return part;
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81972/new/
https://reviews.llvm.org/D81972
Files:
jasonliu added inline comments.
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596
}
+ // Include the filename in the symbol name. Including "sub_" matches gcc
jasonliu wrote:
> jasonliu wrote:
> > I think this patch is missing what @hubert.reinterpretcast
jasonliu added inline comments.
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596
}
+ // Include the filename in the symbol name. Including "sub_" matches gcc
jasonliu wrote:
> I think this patch is missing what @hubert.reinterpretcast mentioned in
>
Xiangling_L updated this revision to Diff 271389.
Xiangling_L marked an inline comment as done.
Xiangling_L added a comment.
Minor change;
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81972/new/
https://reviews.llvm.org/D81972
Files:
jasonliu added inline comments.
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596
}
+ // Include the filename in the symbol name. Including "sub_" matches gcc
I think this patch is missing what @hubert.reinterpretcast mentioned in
Xiangling_L created this revision.
Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Xiangling_L edited the summary of this revision.
Tidy up some code of `EmitCXXGlobalInitFunc()` and `EmitCXXGlobalDtorFunc()`as
14 matches
Mail list logo
