bsaleil added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:10339
+ if (Context.getTargetInfo().getTriple().isPPC64())
+CheckPPCMMAType(RetValExp->getType(), ReturnLoc);
}
NeHuang wrote:
> CheckPPCMMAType returns bool value. Do we need add it
NeHuang added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:10339
+ if (Context.getTargetInfo().getTriple().isPPC64())
+CheckPPCMMAType(RetValExp->getType(), ReturnLoc);
}
CheckPPCMMAType returns bool value. Do we need add it in the if condit
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf976ba613958: [PowerPC] Add Sema checks for MMA types
(authored by bsaleil).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
amyk accepted this revision as: amyk.
amyk added a comment.
This revision is now accepted and ready to land.
Overall LGTM, thanks for addressing comments Baptiste!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82035/new/
https://reviews.llvm.org/D8
bsaleil updated this revision to Diff 302918.
bsaleil added a comment.
Change function name and improve comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82035/new/
https://reviews.llvm.org/D82035
Files:
clang/include/clang/Basic/DiagnosticS
amyk added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:3312
+// if the type is invalid.
+bool Sema::CheckPPCValidType(QualType Type, SourceLocation TypeLoc) {
+ if (Type->isPointerType() || Type->isArrayType())
Would `CheckPPCMMAType` be a bett
amyk added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:3310
+// Check that the given type is a valid type for the PPC target. Return true
+// if the type is invalid.
Would this be a better comment for this function (since it may be confusing to
bsaleil updated this revision to Diff 301010.
bsaleil added reviewers: nemanjai, saghir, lei, rsmith.
bsaleil added a comment.
Herald added a subscriber: dexonsmith.
Rebasing patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82035/new/
https://re