This revision was automatically updated to reflect the committed changes.
Closed by commit rGef597eda8efc: [sve][acle] Add SVE BFloat16 extensions.
(authored by fpetrogalli).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82141/new/
fpetrogalli updated this revision to Diff 272480.
fpetrogalli added a comment.
Formatting changes. NFC.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82141/new/
https://reviews.llvm.org/D82141
Files:
clang/include/clang/Basic/arm_sve.td
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1811
+def int_aarch64_sve_cvt_bf16f32 : Builtin_SVCVT<"svcvt_bf16_f32_m",
llvm_nxv8bf16_ty,
sdesmalen added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1345
+: Intrinsic<[llvm_nxv4f32_ty],
+[llvm_nxv4f32_ty,
+ llvm_nxv8bf16_ty,
nit: keep this on one line.
Repository:
rG LLVM Github
fpetrogalli updated this revision to Diff 272170.
fpetrogalli marked 7 inline comments as done.
fpetrogalli added a comment.
Thank you for the review @sdesmalen!
Francesco
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82141/new/
fpetrogalli added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1811
+def int_aarch64_sve_cvt_bf16f32 : Builtin_SVCVT<"svcvt_bf16_f32_m",
llvm_nxv8bf16_ty, llvm_nxv8i1_ty, llvm_nxv4f32_ty>;
+def int_aarch64_sve_cvtnt_bf16f32 :
sdesmalen added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:494
+let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in {
+ def SVBFDOT : SInst<"svbfdot[_{0}]", "dd$$", "f", MergeNone,
"aarch64_sve_bfdot">;
+ def SVBFMLALB : SInst<"svbfmlalb[_{0}]",
fpetrogalli created this revision.
fpetrogalli added reviewers: sdesmalen, ctetreau, efriedma, david-arm.
Herald added subscribers: llvm-commits, cfe-commits, psnobl, rkruppe,
hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added projects: clang, LLVM.
List of
