[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

baloghadamsoftware added a comment. In D82185#2124948 , @thakis wrote: > This (or a follow-up) broke tests on windows: > http://45.33.8.238/win/18877/step_7.txt > > Please take a look and revert for now if it takes a while to fix. It was this one:

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

thakis added a comment. This (or a follow-up) broke tests on windows: http://45.33.8.238/win/18877/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82185/new/

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e63b190af76: [Analyzer] Handle pointer implemented as iterators in iterator checkers (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D82185?vs=272973=274700#toc

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. Thanks, it LGTM now! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82185/new/ https://reviews.llvm.org/D82185 ___ cfe-commits

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

baloghadamsoftware updated this revision to Diff 272973. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82185/new/ https://reviews.llvm.org/D82185 Files:

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

gamesh411 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:623 + + auto TempState = advancePosition(State, OldVal, OK, Offset); + const IteratorPosition *NewPos = getIteratorPosition(TempState, OldVal); Same as in the

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

baloghadamsoftware updated this revision to Diff 272469. baloghadamsoftware retitled this revision from "[Analyzer][WIP] Handle pointer implemented as iterators in iterator checkers" to "[Analyzer] Handle pointer implemented as iterators in iterator checkers". baloghadamsoftware edited the