This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG52ff86d25598: [AST] Fix traversal over CXXConstructExpr in
Syntactic mode (authored by stephenkelly).
Repository:
rG LLVM Github Monorepo
CHANGES
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82278/new/
https://reviews.llvm.org/D82278
___
cfe-commits mailing list
cfe-commit
steveire updated this revision to Diff 301636.
steveire added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82278/new/
https://reviews.llvm.org/D82278
Files:
clang/lib/AST/Expr.cpp
clang/lib/AST/ParentMapContext.cpp
clang/u
ymandel added inline comments.
Comment at: clang/lib/AST/Expr.cpp:2822
+ if (SE->getSourceRange() == E->getSourceRange())
+return Cast->getSubExpr();
+}
nit: just `return SE`?
Comment at: clang/unittests/ASTMatchers/ASTMatchers
steveire marked 2 inline comments as done.
steveire added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp:80
auto Matches =
- match(expr(hasDescendant(typeLoc().bind("t"))), *E, *Result.Context);
+ match(traverse(TK_AsIs, expr(h
steveire updated this revision to Diff 300550.
steveire added a comment.
Rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82278/new/
https://reviews.llvm.org/D82278
Files:
clang-tools-extra/clang-tidy/bugprone/ThrowKeywordMissingCheck.cpp
ymandel added a comment.
Thanks for this fix!
Comment at: clang/lib/AST/Expr.cpp:3001
Expr *A = C->getArg(0);
-if (A->getSourceRange() == SR || !isa(C))
+if (A->getSourceRange() == SR || C->isElidable()) {
E = A;
aaron.ballma
aaron.ballman added reviewers: rsmith, sammccall.
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp:80
auto Matches =
- match(expr(hasDescendant(typeLoc().bind("t"))), *E, *Result.Context);
+ match(traverse(TK_
steveire created this revision.
steveire added reviewers: klimek, ymandel.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Skip over elidable nodes, and ensure that intermediate
CXXFunctionalCastExpr nodes are also skipped if they are semantic.
Repository:
rG LLVM Github
