[PATCH] D82360: Add StringLiteral to SyntaxTree

2020-06-25 Thread Eduardo Caldas via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG466e8b7ea6e1: Add StringLiteral to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82360?vs=273346&id=273438#toc Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D82360: Add StringLiteral to SyntaxTree

2020-06-25 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 273346. eduucaldas added a comment. Add unicode tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82360/new/ https://reviews.llvm.org/D82360 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib

[PATCH] D82360: Add StringLiteral to SyntaxTree

2020-06-24 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM with improved testing. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1237 + "a\n"; + L"a"; +} Could you add some non-ASCII character

[PATCH] D82360: Add StringLiteral to SyntaxTree

2020-06-23 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82360 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/B