[PATCH] D82362: Move default module cache from system temporary directory

thakis added a comment. Reverted for now in 4d5c4489435dc1cb3d4989614e96b157c74afdea Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82362/new/ https://reviews.llvm.org/D82362

[PATCH] D82362: Move default module cache from system temporary directory

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/mac/16222/step_11.txt Please take a look and revert for now if this takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82362/new/

[PATCH] D82362: Move default module cache from system temporary directory

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb26838ceffb: [clang driver] Move default module cache from system temporary directory (authored by davezarzycki). Changed prior to commit: https://reviews.llvm.org/D82362?vs=272655=273674#toc

[PATCH] D82362: Move default module cache from system temporary directory

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3253 + CmdArgs.push_back(Args.MakeArgString(Path)); +} } davezarzycki wrote: > sammccall wrote: > > what happens in the else case? >

[PATCH] D82362: Move default module cache from system temporary directory

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82362/new/ https://reviews.llvm.org/D82362

[PATCH] D82362: Move default module cache from system temporary directory

davezarzycki marked an inline comment as done. davezarzycki added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3253 + CmdArgs.push_back(Args.MakeArgString(Path)); +} } sammccall wrote: > what happens in the else case? No module

[PATCH] D82362: Move default module cache from system temporary directory

sammccall added a comment. Can you update the commit message to also reflect the change in `cache_directory` behavior? (This is going to move clangd index files on macOS, for instance... I think that's OK, but let's not bury it) Comment at:

[PATCH] D82362: Move default module cache from system temporary directory

davezarzycki created this revision. davezarzycki added reviewers: compnerd, aprantl, jakehehrlich, espindola, respindola, ilya-biryukov, pcc, sammccall. davezarzycki added projects: clang, LLVM. Herald added a subscriber: hiraditya. 1. Shared writable directories like /tmp are a security