[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

This revision was automatically updated to reflect the committed changes. Closed by commit rGea563daae523: [Analyzer] Fix errors in iterator modeling (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82385/new/

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

gamesh411 accepted this revision. gamesh411 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:530-532 const auto *Pos = getIteratorPosition(State, LHS); if (!Pos) return;

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:530-532 const auto *Pos = getIteratorPosition(State, LHS); if (!Pos) return; Szelethus

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:530-532 const auto *Pos = getIteratorPosition(State, LHS); if (!Pos) return; I fear this might be a stupid question, but what's up with `5 + it`? Why

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

baloghadamsoftware updated this revision to Diff 272950. baloghadamsoftware edited the summary of this revision. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82385/new/ https://reviews.llvm.org/D82385 Files:

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

baloghadamsoftware updated this revision to Diff 272927. baloghadamsoftware added a comment. Code reformatted according to Lint Pre-Merge check suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82385/new/ https://reviews.llvm.org/D82385 Files:

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

gamesh411 added a comment. Hey! See my inline comments, but after those and a quick clang-format, it looks good. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:543 - auto NewState = + auto TmpState = advancePosition(State, LHS, Op, *value);

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus, gamesh411, martong, balazske. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet,