[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

2020-07-01 Thread Zoe Carver via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe7c5da57a5f3: [CodeGen] Add public function to emit C++ destructor call. (authored by zoecarver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82392/new/ h

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

2020-07-01 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82392/new/ https://reviews.llvm.org/D82392 ___

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

2020-06-30 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver added a comment. @rjmccall I updated this patch to introduce the function `getCXXDestructorImplicitParam` instead. This should be closer to D79942 . It seems like there is never more than one implicit parameter so, I just have it return a single `llvm:

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

2020-06-30 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver updated this revision to Diff 274616. zoecarver added a comment. - Remove `emitCXXDestructorCall` and add `getCXXDestructorImplicitParam`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82392/new/ https://reviews.llvm.org/D82392 Files:

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

2020-06-29 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Can we do a design more like what we did with constructors? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82392/new/ https://reviews.llvm.org/D82392 ___ cfe-commits mailing li

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

2020-06-23 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver created this revision. zoecarver added reviewers: rjmccall, mboehme. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds `CodeGen::emitCXXDestructorCall`, a function that creates a CodeGenFunction using the arguments provided, then invokes CodeGenFunction::EmitC