[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

jdoerfert added a comment. In D82470#2116581 , @SouraVX wrote: > Overall this seems great Thanks! I have one minor concern: > This patch seems to do 2 things: Support for nested parallel regions(which > was crashing earlier) and some infrastructure

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

SouraVX added a comment. Overall this seems great Thanks! I have one minor concern: This patch seems to do 2 things: Support for nested parallel regions(which was crashing earlier) and some infrastructure change(introducing AllocBuilder..). I'm not sure of this, but is it possible to separate

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

anchu-rajendran added a comment. Herald added a subscriber: rogfer01. The change looks good to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 ___

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings fghanim wrote: > jdoerfert wrote: > >

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

fghanim added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings jdoerfert wrote: > fghanim wrote: > > What's the benefit of this over just maintaining

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings fghanim wrote: > What's the benefit of

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

fghanim added a comment. Thanks for the Patch. I have few questions to help me understand what's going on. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings What's

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

jdoerfert created this revision. jdoerfert added reviewers: anchu-rajendran, kiranktp, fghanim. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, guansong, bollu, hiraditya, yaxunl. Herald added projects: clang, LLVM. During code generation we might change/add basic blocks so