This revision was automatically updated to reflect the committed changes.
Closed by commit rG8cce7af090bd: [SourceManager] don't check invalid param
of getLocalSLocEntry() (authored by nickdesaulniers).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D8
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82498/new/
https://reviews.llvm.org/D82498
__
nickdesaulniers updated this revision to Diff 273449.
nickdesaulniers added a comment.
- drop `Invalid` param from getLocalSLocEntry
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82498/new/
https://reviews.llvm.org/D82498
Files:
clang/include/cl
kadircet added inline comments.
Comment at: clang/include/clang/Basic/SourceManager.h:1649
const SrcMgr::SLocEntry &getLocalSLocEntry(unsigned Index,
bool *Invalid = nullptr) const {
assert(Index < LocalSLocEntryTable.size() &
kadircet added inline comments.
Comment at: clang/include/clang/Basic/SourceManager.h:1649
const SrcMgr::SLocEntry &getLocalSLocEntry(unsigned Index,
bool *Invalid = nullptr) const {
assert(Index < LocalSLocEntryTable.size() &
nickdesaulniers created this revision.
nickdesaulniers added a reviewer: kadircet.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
nickdesaulniers retitled this revision from "[SourceManager] don't check
Invalid param of getLocalSLocEntry()" to "[SourceManager] don't check i
