[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added a comment. Reverted in https://github.com/llvm/llvm-project/commit/ff5ccf258e297df29f32d6b5e4fa0a7b95c44f9c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82501/new/ https://reviews.llvm.org/D82501

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added a comment. Ops, I accidentally removed the C tests... I'll revert, add the tests and recommit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82501/new/ https://reviews.llvm.org/D82501

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa15722c5ce47: [sve][acle] Add reinterpret intrinsics for brain float. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82501/new/

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli updated this revision to Diff 273737. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. I removed the duplicate tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82501/new/ https://reviews.llvm.org/D82501

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-bitcast-bfloat.ll:8 + +define @bitcast_bfloat_to_i8( %v) { +; CHECK-LABEL: bitcast_bfloat_to_i8: david-arm wrote: > Aren't these tests all

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread David Sherwood via Phabricator via cfe-commits
david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. Can you remove the duplicate tests before submitting? Otherwise LGTM! Comment at: llvm/test/CodeGen/AArch64/sve-bitcast-bfloat.ll:8 + +define @bitcast_bfloat_to_i8(

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-25 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli updated this revision to Diff 273399. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. @david-arm, at the end I decided to add the `ASM-NOT` test, it was easy and came for free. Also, I have moved the IR tests in the file with all other bitcasts, using a

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-25 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_reinterpret-bfloat.c:5 + +#include + david-arm wrote: > Hi @fpetrogalli, in the same way that you asked @kmclaughlin

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-25 Thread David Sherwood via Phabricator via cfe-commits
david-arm added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_reinterpret-bfloat.c:5 + +#include + Hi @fpetrogalli, in the same way that you asked @kmclaughlin if she could add the ASM-NOT check line in her patch, are you

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-24 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli created this revision. fpetrogalli added reviewers: kmclaughlin, efriedma, ctetreau, sdesmalen, david-arm. Herald added subscribers: llvm-commits, cfe-commits, psnobl, rkruppe, hiraditya, tschuett. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo