This revision was automatically updated to reflect the committed changes.
Closed by commit rG19e883fc5988: [SVE] Remove calls to
VectorType::getNumElements from clang (authored by ctetreau).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82582/new/
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82582/new/
https://reviews.llvm.org/D82582
ctetreau updated this revision to Diff 287755.
ctetreau marked 4 inline comments as done.
ctetreau added a comment.
address code review issues, rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82582/new/
https://reviews.llvm.org/D82582
Files:
ctetreau marked 8 inline comments as done.
ctetreau added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:1765
}
auto *VectorTy = dyn_cast(
cast(Addr.getPointer()->getType())->getElementType());
c-rhodes wrote:
> cast here
that would be a
ctetreau updated this revision to Diff 284926.
ctetreau added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82582/new/
https://reviews.llvm.org/D82582
Files:
clang/lib/CodeGen/CGAtomic.cpp
clang/lib/CodeGen/CGBuiltin.cpp
ctetreau planned changes to this revision.
ctetreau added a comment.
I plan to investigate the changes proposed by @c-rhodes. I'm a bit swamped
right now so it may take a bit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82582/new/
c-rhodes added a comment.
there's a few places the `getNumElements` calls can be fixed by getting the
initial cast right
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5986
case NEON::BI__builtin_neon_vqrdmulh_lane_v: {
auto *RTy = cast(Ty);
if (BuiltinID ==
ctetreau updated this revision to Diff 280254.
ctetreau added a comment.
address code review issues
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82582/new/
https://reviews.llvm.org/D82582
Files:
clang/lib/CodeGen/CGAtomic.cpp
ctetreau marked an inline comment as done.
ctetreau added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5612-5613
llvm::VectorType *VTy = GetNeonType(this, Type, HasLegalHalfType, false,
AllowBFloatArgsAndRet);
c-rhodes added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5612-5613
llvm::VectorType *VTy = GetNeonType(this, Type, HasLegalHalfType, false,
AllowBFloatArgsAndRet);
llvm::Type *Ty = VTy;
Is there a
ctetreau updated this revision to Diff 279370.
ctetreau added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82582/new/
https://reviews.llvm.org/D82582
Files:
clang/lib/CodeGen/CGAtomic.cpp
clang/lib/CodeGen/CGBuiltin.cpp
ctetreau created this revision.
Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett.
Herald added a reviewer: efriedma.
Herald added a project: clang.
ctetreau added a child revision: D78127: [SVE] Mark
VectorType::getNumElements() deprecated.
Repository:
rG LLVM Github Monorepo
12 matches
Mail list logo
