This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG860aefd0784e: [clang-tidy][NFC] Remove unnecessary includes
throughout clang-tidy header files (authored by njames93).
njames93 updated this revision to Diff 274129.
njames93 added a comment.
Remove unnecessary test changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82661/new/
https://reviews.llvm.org/D82661
Files:
clang-tools-extra/clang-tidy/ClangTidy.cpp
njames93 marked an inline comment as done.
njames93 added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/checkers/google-module.cpp:4
+// CHECK-DAG: {{- key:
*google-readability-braces-around-statements.ShortStatementLines[[:space:]]
value: *'1'}}
+//
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, though I think this should be landed in two commits (one for the headers,
one for the tests).
Comment at: clang-tools-extra/test/clang-tidy/checkers/google-module.cpp:4
+// CHECK-DAG: {{- key:
njames93 updated this revision to Diff 273894.
njames93 retitled this revision from "[clang-tidy][NFC] Remove unnecessary
includes throughout clang-tidy header files" to "[clang-tidy][NFC} Remove
unnecessary includes throughout clang-tidy header files".
njames93 edited the summary of this
dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.
> Plus replacing a few std::map with llvm::StringMap
That doesn't sound NFC since it changes ordering semantics. It seems to me like
it should be done separately from the
njames93 updated this revision to Diff 273792.
njames93 added a comment.
Herald added subscribers: usaxena95, kadircet, jkorous.
Fix some issues with tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82661/new/
https://reviews.llvm.org/D82661
Eugene.Zelenko added a comment.
I think will be good idea to run Include What You Use.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82661/new/
https://reviews.llvm.org/D82661
___
cfe-commits mailing
