[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

This revision was automatically updated to reflect the committed changes. njames93 marked an inline comment as done. Closed by commit rGf51a319cacd4: [ASTMatchers] Enhanced support for matchers taking Regex arguments (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 marked 5 inline comments as done. njames93 added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:124 +llvm::Optional getRegexFlag(llvm::StringRef Flag) { + for (auto : RegexMap) { +if (Flag == StringFlag.first)

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 274846. njames93 added a comment. Small refactor based on comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:124 +llvm::Optional getRegexFlag(llvm::StringRef Flag) { + for (auto : RegexMap) { +if (Flag == StringFlag.first) `const auto &` (same below)

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 274591. njames93 added a comment. Added best guess support for parsing RegexFlags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files:

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1952 +std::shared_ptr createAndVerifyRegex(StringRef Regex, + llvm::Regex::RegexFlags Flags, njames93

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 274493. njames93 marked 2 inline comments as done. njames93 added a comment. Fix missing return statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files:

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 marked 7 inline comments as done. njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1952 +std::shared_ptr createAndVerifyRegex(StringRef Regex, + llvm::Regex::RegexFlags

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1952 +std::shared_ptr createAndVerifyRegex(StringRef Regex, + llvm::Regex::RegexFlags Flags, Is there a

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 273957. njames93 added a comment. Include matcher name in error message when failing to build a regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files:

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 273960. njames93 added a comment. Moved the code to build and verify the regex out of the macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files:

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Added new Macros `AST(_POLYMORPHIC)_MATCHER_REGEX(_OVERLOAD)` that define a matchers that take a regular expression