[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang/test/CoverageMapping/coroutine.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fcoroutines-ts -std=c++14 -emit-llvm -fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping %s | FileCheck %s +

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82928#2126018 , @fhahn wrote: > Looks like this causes a bunch of build bot failures, e.g > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31465 b > > It would be great if you could take a look. Fix patch

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82928#2126018 , @fhahn wrote: > Looks like this causes a bunch of build bot failures, e.g > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31465 b > > It would be great if you could take a look. Let me

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82928#2126018 , @fhahn wrote: > Looks like this causes a bunch of build bot failures, e.g > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31465 b > > It would be great if you could take a look. Looks

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. Looks like this causes a bunch of build bot failures, e.g http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31465 b It would be great if you could take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG565e37c7702d: [Coroutines] Fix code coverage for coroutine (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82928/new/

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 274836. lxfind added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82928/new/ https://reviews.llvm.org/D82928 Files: clang/lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-07-01 Thread Brian Gesiak via Phabricator via cfe-commits
modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Excellent, thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82928/new/ https://reviews.llvm.org/D82928

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

2020-06-30 Thread Xun Li via Phabricator via cfe-commits
lxfind created this revision. lxfind added reviewers: lewissbaker, modocache, junparser. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, source-based coverage analysis does not work properly for coroutine. This patch adds processing of coroutine body and