[PATCH] D82930: [HIP] Fix rocm detection

thakis added a comment. Great, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82930/new/ https://reviews.llvm.org/D82930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl added a comment. In D82930#2145827 , @njames93 wrote: > This is causing a test case to fail on mac > http://45.33.8.238/mac/17048/step_7.txt 5d2c3e031a6861b3e95673d0e238c09938dd9c0d

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl added a comment. In D82930#2145914 , @thakis wrote: > This breaks check-clang on macOS: http://45.33.8.238/mac/17053/step_7.txt > > The output contains > > 5: clang: warning: argument unused during compilation: >

[PATCH] D82930: [HIP] Fix rocm detection

thakis added a comment. …oh, njames said that already 5h ago :) I guess I'll wait another hour or two, and then I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82930/new/ https://reviews.llvm.org/D82930

[PATCH] D82930: [HIP] Fix rocm detection

thakis added a comment. This breaks check-clang on macOS: http://45.33.8.238/mac/17053/step_7.txt The output contains 5: clang: warning: argument unused during compilation: '--rocm-path=/Users/thakis/src/llvm-project/clang/test/Driver/Inputs/rocm' [-Wunused-command-line-argument] which if

[PATCH] D82930: [HIP] Fix rocm detection

njames93 added a comment. Herald added a subscriber: ormris. This is causing a test case to fail on mac http://45.33.8.238/mac/17048/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82930/new/ https://reviews.llvm.org/D82930

[PATCH] D82930: [HIP] Fix rocm detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG849d4405f534: [HIP] Fix rocm detection (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D82930?vs=277095=277214#toc Repository: rG LLVM Github

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl marked 11 inline comments as done. yaxunl added a comment. thanks. will fix when commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82930/new/ https://reviews.llvm.org/D82930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82930: [HIP] Fix rocm detection

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. LGTM in principle. Few style comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:161 +unsigned Minor = 0; +auto Splits =

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl updated this revision to Diff 277095. yaxunl marked 2 inline comments as done. yaxunl added a comment. Herald added a reviewer: dang. Separate detecting ROCm path and device library path. Assume 3.5 as default HIP version. If -rocm-path is specified, do not require version file to exist.

[PATCH] D82930: [HIP] Fix rocm detection

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > tra wrote: > > arsenm wrote: > > > yaxunl wrote: >

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) tra wrote: > arsenm wrote: > > yaxunl wrote: > > > yaxunl wrote:

[PATCH] D82930: [HIP] Fix rocm detection

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > yaxunl wrote: > > yaxunl wrote: > > > yaxunl wrote:

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) yaxunl wrote: > yaxunl wrote: > > yaxunl wrote: > > > tra wrote:

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) yaxunl wrote: > tra

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) tra wrote: > arsenm

[PATCH] D82930: [HIP] Fix rocm detection

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > yaxunl wrote: > > arsenm wrote: > > > arsenm wrote:

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) yaxunl wrote: > arsenm wrote: > > arsenm wrote: > > > yaxunl

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > arsenm

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > yaxunl wrote: > > arsenm wrote: > > > I don't

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) yaxunl wrote: > arsenm wrote: > > I don't think the detection

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > I don't

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) I don't think the detection should fail if this is missing

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl created this revision. yaxunl added reviewers: tra, arsenm. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. Do not detect device library by default in rocm detector. Only detect device library in HIP toolchain. Detect rocm path by version file in host toolchains. Also added