[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. Herald added a subscriber: frasercrmck. Looking back at this I'm not so sure if it was beneficial to divert from the generic behavior and print each function for each prefix. Having a function only in one run line but not the other should work perfectly fine as long

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2290157 , @greened wrote: > In D83004#2287851 , @dmajor wrote: > >> The expensive-checks bots have been red for several days. Could you please >> take a look or revert? > >

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2287851 , @dmajor wrote: > The expensive-checks bots have been red for several days. Could you please > take a look or revert? Working on it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

dmajor added a comment. The expensive-checks bots have been red for several days. Could you please take a look or revert? riscv_generated_funcs.test: *** Bad machine code: MBB exits via unconditional fall-through but ends with a barrier instruction! *** - function:check_boundaries -

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

chill added a comment. Some tests started failing: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/9071 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D83004

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

thakis added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:645 + added = set() + for prefixes, tool_args, *rest in prefix_list: +for prefix in prefixes: LLVM still supports Python 2.7. This breaks devs and bots still using 2.7. Please

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

arichardson added a comment. I think this approach seems fine, just a few very minor comments inlines. In D83004#2280363 , @greened wrote: > In D83004#2278681 , @arichardson > wrote: > >> Maybe add another test

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2278681 , @arichardson wrote: > Maybe add another test that checks for the @__cxx_global_var_init() > constructor function? > E.g. something like this: > > int init_func(int arg) { > return arg + 1; > } > >

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:274-277 prefixes = p[0] for prefix in prefixes: func_dict.update({prefix: dict()}) +func_order.update({prefix: []}) arichardson wrote: > This should

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. This works for me. @arichardson you want to continue the review or should we take this and if needed improve upon it in subsequent patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

arichardson added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:331 +# are ordered by prefix instead of by function as in "normal" +# mode. +if '-emit-llvm' in clang_args: jdoerfert wrote: > This is all

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

arichardson added a comment. Maybe add another test that checks for the @__cxx_global_var_init() constructor function? E.g. something like this: int init_func(int arg) { return arg + 1; } int my_global = init_func(2); Comment at:

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2274687 , @jdoerfert wrote: > >> Do you mean a test for recognizing the option in `common.py`? I'm not sure >> what you're asking for here. > > The function is recognized in common.py, right? Can't you run the >

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. In D83004#2274573 , @greened wrote: > In D83004#2168427 , @jdoerfert wrote: > >> Due to D82995 I realized we should have a >> test of this in

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2168427 , @jdoerfert wrote: > Due to D82995 I realized we should have a > test of this in `llvm/test/tools/UpdateTestChecks` as well. Do you mean a test for recognizing the option in

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2250897 , @jdoerfert wrote: > reverse ping? Heh. Getting back to this now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D83004

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. reverse ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D83004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. Due to D82995 I realized we should have a test of this in `llvm/test/tools/UpdateTestChecks` as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the generalization. We'll add update_test support next for the opt case, e.g., for D83635 . Comment at:

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened updated this revision to Diff 279932. greened added a comment. Updated to move the option into `common.py`. Also had to rework the output loop to account for differences between python 2 and 3. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source')

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source') parser.add_argument('tests', nargs='+')

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source')

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source') parser.add_argument('tests', nargs='+')

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source')

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2134303 , @greened wrote: > > I don't particularly like this mode dichotomy but unifying it would > necessitate updating a whole lot of clang tests. Axtually that's not strictly true, It would just change the

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2129362 , @jdoerfert wrote: > This is great! Just a few days ago I added a TODO in one of the tests I > created asking for this: D82722 :) Glad to help! > Will this work for all test

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source')

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened updated this revision to Diff 275831. greened added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed various bugs, added tests. This now has two modes because generated function output can't be ordered with respect to source file functions. When