[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

balazske added a comment. Crash is fixed here: D84843 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83115/new/ https://reviews.llvm.org/D83115 ___ cfe-commits mailing

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

NoQ added a comment. Whoops, i meant to post the comment in https://reviews.llvm.org/rG22a084cfa337d5e5ea90eba5261f7937e28d250b#937772 here. Anyway, i found a crash caused by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83115/new/

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG22a084cfa337: [Analyzer] Report every bug if only uniqueing location differs. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1136-1137 ID.Add(getLocation()); + ID.Add(getUniqueingLoc()); + ID.AddPointer(getUniqueingLoc().isValid() ?

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

Szelethus added reviewers: NoQ, vsavchenko, xazax.hun, martong. Szelethus added a subscriber: NoQ. Szelethus added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1136-1137 ID.Add(getLocation()); + ID.Add(getUniqueingLoc()); +

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:333 + if (XL.isValid() && YL.isInvalid()) +return false; std::pair XOffs = XL.getDecomposedLoc(); baloghadamsoftware wrote: > Why

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

baloghadamsoftware added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:333 + if (XL.isValid() && YL.isInvalid()) +return false; std::pair XOffs = XL.getDecomposedLoc(); Why this asymmetry? Comment at:

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Two CSA bug