[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

This revision was automatically updated to reflect the committed changes. Closed by commit rG5809a32e7c2d: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ ht

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

calixte accepted this revision. calixte added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://reviews.llvm.org/D83149 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, I still would appreciate @calixte feedback here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://re

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://reviews.llvm.org/D83149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay added a comment. `compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c.gcov` is clumsy to update. The filename is also wrong: gcov has nothing to do with instrprof. I'll update the tests separately like my fba8523fb55c8e3bc853df7a250845cf51e5fc99

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay updated this revision to Diff 276173. MaskRay marked 6 inline comments as done. MaskRay added a comment. Test __gcov_dump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://reviews.llvm.org/D83149 Files: clang/lib/Driver/To

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille added inline comments. Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush"); - if (gcov_flush1 == NULL) { -fprintf(stderr, "unable to find __gcov

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay marked 6 inline comments as done. MaskRay added inline comments. Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush"); - if (gcov_flush1 == NULL) { -fprint

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille added a comment. Some nit-picking, lgtm otherwise. Please wait for @calixte review though :-) Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush");

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay created this revision. MaskRay added reviewers: calixte, marco-c, serge-sans-paille, vsk. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. GCC r187297 (2012-05) introduced __gcov_dump and __gcov_reset. __gcov_flu