This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG05eeda9752b3: [clang][cli] Turn arcmt-* options into a
single option (authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
jansvoboda11 commandeered this revision.
jansvoboda11 added a reviewer: dang.
jansvoboda11 added a comment.
Taking over this patch, as Daniel is no longer involved.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83315/new/
https://reviews.llvm.org/D
dang updated this revision to Diff 276438.
dang added a comment.
Instead of using a Separate option kind (-arcmt-action action) use a Joined
kind (-arcmt-action=*)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83315/new/
https://reviews.llvm.org/D
Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.
I have a slight preference for `-arcmt-action=`, but up to you if you want to
change it. Otherwise LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
dang created this revision.
dang added a reviewer: Bigcheese.
Herald added subscribers: llvm-commits, cfe-commits, dexonsmith.
Herald added projects: clang, LLVM.
- The new option, -arcmt-action, is a simple enum based option.
- The driver is modified to translate the existing -ccc-acmt-* options
