[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc7d2908ab38: [OpenMP] Use common interface to access GPU Grid Values (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https://reviews.llvm.org/D83492

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam updated this revision to Diff 278799. saiislam added a comment. Corrected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https://reviews.llvm.org/D83492 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp Index:

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam updated this revision to Diff 278787. saiislam added a comment. Removed getNVPTXWarpSize() changes for a separate patch and rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https://reviews.llvm.org/D83492 Files:

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:654 + unsigned LaneIDBits = + CGF.getTarget().getGridValue(llvm::omp::GV_Warp_Size_Log2); return Bld.CreateAShr(getNVPTXThreadID(CGF),

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam added a comment. In D83492#2142086 , @JonChesterfield wrote: > Changing to getGridValue would be useful for sharing parts of this with > amdgcn. > > The aomp toolchain handles codegen for amdgcn by adding if (isAMDGCN) to this > file. Until

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:654 + unsigned LaneIDBits = + CGF.getTarget().getGridValue(llvm::omp::GV_Warp_Size_Log2); return Bld.CreateAShr(getNVPTXThreadID(CGF), LaneIDBits, "nvptx_warp_id");

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

JonChesterfield added a comment. Changing to getGridValue would be useful for sharing parts of this with amdgcn. The aomp toolchain handles codegen for amdgcn by adding if (isAMDGCN) to this file. Until such time as tregions obsoletes this code, I think we should go with layers instead of

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam created this revision. saiislam added reviewers: jdoerfert, ABataev, JonChesterfield. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl, jholewinski. Herald added a project: clang. Use common interface for accessing target specific GPU grid values in NVPTX OpenMP codegen