This revision was automatically updated to reflect the committed changes.
Closed by commit rGfbb30c31fefc: [clang] Add override to virtual
function overrides generated by… (authored by logan-5).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
logan-5 added a comment.
Thanks! I would appreciate any help committing this.
I have a few of these kinds of NFC `override` patches in flight, and I'd love
to be able to commit them myself and not bother people. I wonder what the
process of gaining commit access looks like? I've been a
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83616/new/
https://reviews.llvm.org/D83616
logan-5 created this revision.
logan-5 added reviewers: rsmith, aaron.ballman, john.brawn.
logan-5 added a project: clang.
Herald added a subscriber: cfe-commits.
ClangAttrEmitter.cpp generates `ParsedAttr` derived classes with virtual
overrides in them (which end up in AttrParsedAttrImpl.inc);
