[PATCH] D83652: Merge some of the PCH object support with modular codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGb198de67e0ba: Merge some of the PCH object support with modular codegen (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83652/new/

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie added a comment. @hans @llunak - sounds like you're both fine with this? Either of you mind to give it a formal approval, if that's the case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83652/new/ https://reviews.llvm.org/D83652

[PATCH] D83652: Merge some of the PCH object support with modular codegen

hans added a comment. > Thanks for checking! So, in summary: This seems to work fine for Chromium, > but Chromium isn't really exercising this functionality (only insofar as the > functionality is enabled, but essentially a no-op)? Yup. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D83652: Merge some of the PCH object support with modular codegen

llunak added a comment. > @llunak Would you be able to test this on anything you've got? No, but thinking more about this, I think dllexport specifically voids the possible problems I listed. If I'm getting it right, dllexport is used only for code in the current library, so codegen won't

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie added a comment. In D83652#2161924 , @hans wrote: > In D83652#2159585 , @dblaikie wrote: > > > @hans - could you perhaps give me a quick summary of commands I could use > > to test this feature in

[PATCH] D83652: Merge some of the PCH object support with modular codegen

hans added a comment. In D83652#2159585 , @dblaikie wrote: > @hans - could you perhaps give me a quick summary of commands I could use to > test this feature in Chromium (or anything else you might suggest) on a Linux > box? I don't have a Windows

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie added a comment. @hans - could you perhaps give me a quick summary of commands I could use to test this feature in Chromium (or anything else you might suggest) on a Linux box? I don't have a Windows machine, or any projects that use PCH. (or if you'd be willing to test this, that'd

[PATCH] D83652: Merge some of the PCH object support with modular codegen

llunak added a comment. In D83652#2147539 , @dblaikie wrote: > Not quite - it's intended to implement the D48426 > functionality using an implementation > strategy that is closer to modular code generation. Removing the

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie added a comment. In D83652#2146732 , @llunak wrote: > The patch is incomplete, isn't it? It removes DeclIsFromPCHWithObjectFile(), > but it's still called from ASTContext::DeclMustBeEmitted(). The description > also mentions updating of the

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie updated this revision to Diff 277449. dblaikie added a comment. Include all the commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83652/new/ https://reviews.llvm.org/D83652 Files: clang/include/clang/AST/ExternalASTSource.h

[PATCH] D83652: Merge some of the PCH object support with modular codegen

hans added a comment. In D83652#2146732 , @llunak wrote: > > Do either of you know if it'd be practical to move to something more > > similar to .pcm handling, where the pch itself is passed to the > > compilation, rather than homed as a side effect of

[PATCH] D83652: Merge some of the PCH object support with modular codegen

llunak added a comment. The patch is incomplete, isn't it? It removes DeclIsFromPCHWithObjectFile(), but it's still called from ASTContext::DeclMustBeEmitted(). The description also mentions updating of the pch-codegen test, but that's not included. But assuming this is intended to replace the

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie created this revision. dblaikie added reviewers: rnk, llunak, hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. I was trying to pick this up a bit when reviewing D48426 (& perhaps D69778 ) -