This revision was automatically updated to reflect the committed changes.
Closed by commit rG29f8c9f6c25d: [WebAssembly] Triple::wasm64 related cleanup
(authored by aardappel).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83713/new/
aardappel updated this revision to Diff 277627.
aardappel added a comment.
Made LLD `is64` optional, so we can know if is set consistently.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83713/new/
https://reviews.llvm.org/D83713
Files:
clang/lib/Driver/ToolChain.cpp
sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.
Comment at: lld/wasm/InputFiles.cpp:583
}
+ config->is64 = t.getArch() == Triple::wasm64;
std::vector keptComdats;
Should we error out here if
aardappel created this revision.
aardappel added reviewers: dschuff, sbc100.
Herald added subscribers: llvm-commits, cfe-commits, sunfish, aheejin,
hiraditya, jgravelle-google.
Herald added projects: clang, LLVM.
A few cases that didn't cover Triple::wasm64 correctly.
Repository:
rG LLVM
