rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83812/new/
https://reviews.llvm.org/D83812
leonardchan updated this revision to Diff 279354.
leonardchan marked an inline comment as done.
leonardchan added a comment.
Add a method to `TargetCodeGenInfo` the returns if the target supports PC
relative PLT relocations,
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGVTables.cpp:633
+ auto Arch = targetTriple.getArch();
+ if (Arch == llvm::Triple::aarch64 || Arch == llvm::Triple::x86_64)
+return false;
Could you add a method to TargetCodeGenInfo for this
leonardchan created this revision.
leonardchan added reviewers: rjmccall, pcc, phosek, mcgrathr, rsmith.
leonardchan added a project: clang.
Herald added subscribers: s.egerton, simoncook, kristof.beyls.
Herald added a reviewer: jdoerfert.
Now that LLVM and LLD support the `R_AARCH64_PLT32`
