[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280383. kbobyrev added a comment. Reset D83831 to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files:

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev abandoned this revision. kbobyrev added a comment. In favor of D84499 with clean diffs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 ___ cfe-commits

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280365. kbobyrev added a comment. Rebase on top of master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:63 +trace::Span Tracer("Remote index server Lookup"); +SPAN_ATTACH(Tracer, "LookupRequest", Request->ShortDebugString()); clangd::LookupRequest Req;

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 278237. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files:

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

sammccall added a comment. Server-side tracing looks nice, but you'll need some flags to allow actually extracting a trace, right? Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:62 grpc::ServerWriter *Reply) override { +

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 278081. kbobyrev added a comment. Rebase on top of parent revision, add more logging on the client side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files:

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83831 Files: