[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. In D83836#2189636 , @NoQ wrote: > These patches look like they're done, maybe let's land them? This one also committed.

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

NoQ added a comment. These patches look like they're done, maybe let's land them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83836/new/ https://reviews.llvm.org/D83836 ___ cfe-commits mailing list

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I think this looks great! P.S. I unforgot why we won't be able to remove the option after all. That's because when we partially evalCall and partially inline, inlining breaks. Like, once we

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

vrnithinkumar marked 2 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:97 +// If a region is removed all of the subregions needs to be removed too. +static ProgramStateRef

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

vrnithinkumar updated this revision to Diff 278628. vrnithinkumar marked 8 inline comments as done. vrnithinkumar added a comment. - Adding a missed todo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83836/new/ https://reviews.llvm.org/D83836

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

vrnithinkumar updated this revision to Diff 278622. vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. - Addressing review comments - Enabling commented out tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83836/new/