[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille added a comment. Commited on your behalf using what I expect to be your official email address :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984

[PATCH] D83984: Explicitly use utf-8 in send_string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3205e2ace43: [scan-view] Explicitly use utf-8 in send_string (authored by Tomas Rix , committed by serge-sans-paille). Repositor

[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM then :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984 __

[PATCH] D83984: Explicitly use utf-8 in send_string

trixirt added a comment. Yes, this break on py2, and py3 the change is a noop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984 ___ cfe-commits mailing list cfe-com

[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille added a comment. According to the doc, `'utf-8'` is already the default encoding, at least on py3, but not on py2. i guess that the problem you're trying to fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://re

[PATCH] D83984: Explicitly use utf-8 in send_string

trixirt created this revision. trixirt added reviewers: serge-sans-paille, michaelplatings. trixirt added a project: clang. Herald added a subscriber: cfe-commits. send_patched_file decodes with utf-8. The default encoder for python 2 is ascii. So it is necessary to also change send_string to use