This revision was automatically updated to reflect the committed changes.
Closed by commit rGf761acfb1a73: [ASTImporter] Add Visitor for
TypedefNameDecls (authored by vabridgers, committed by einvbri
vince.a.bridg...@ericsson.com).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks for the test!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83992/new/
https://reviews.llvm.org/D83992
vabridgers updated this revision to Diff 280700.
vabridgers added a comment.
Adding negative test case that exposes the original problem.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83992/new/
https://reviews.llvm.org/D83992
Files:
vabridgers added a comment.
I discussed with Gabor. We don't feel comfortable landing this without a
covering negative test case, so I'll work on that a little more, see what I can
come up with. Thanks Gabor!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
vabridgers updated this revision to Diff 278630.
vabridgers added a comment.
Fix lint pre-merge check
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83992/new/
https://reviews.llvm.org/D83992
Files:
clang/lib/AST/ASTImporterLookupTable.cpp
vabridgers created this revision.
vabridgers added a reviewer: martong.
Herald added subscribers: cfe-commits, teemperor, rnkovacs.
Herald added a reviewer: a.sidorin.
Herald added a project: clang.
We found a case where Typedef Name Declarations were not being added
correctly when importing
