kbobyrev abandoned this revision.
kbobyrev added a comment.
There are more revisions that are buggy, can't test them all :(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84232/new/
https://reviews.llvm.org/D84232
kbobyrev planned changes to this revision.
kbobyrev added a comment.
Need to exclude everything between 1.26.0 and 1.27.0, not set this as the
minimum (Ubuntu packages are outdated).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84232/new/
kbobyrev added a comment.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=965217 is not going anywhere,
I think we should just add this check and not check for the correct patch on
Debian (and macOS is different anyway).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kbobyrev updated this revision to Diff 299623.
kbobyrev added a comment.
Add macOS version check.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84232/new/
https://reviews.llvm.org/D84232
Files:
clang-tools-extra/clangd/index/remote/README.md
kbobyrev updated this revision to Diff 299618.
kbobyrev added a comment.
Rebase on top of master.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84232/new/
https://reviews.llvm.org/D84232
Files:
clang-tools-extra/clangd/index/remote/README.md
kbobyrev added a comment.
This patch is not ready for review yet; planned changes: check if the version
is between 1.25.0 and 1.26.0-4 and bail out in such cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84232/new/
kbobyrev planned changes to this revision.
kbobyrev added a comment.
Maybe wait for Debian packages to get updated and then whitelist 1.26.0-4 but
fail with anything lower than that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84232/new/
kbobyrev added a comment.
Aww, this might be problematic. Ubuntu has quite old gRPC versions (which are
OK though). The newest is 1.26.0 and it's on Groovy (20.10, unreleased yet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84232/new/
kbobyrev updated this revision to Diff 279497.
kbobyrev added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Check gRPC version for system-installed APT package on Debian-like Linux
distros.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
