[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

This revision was automatically updated to reflect the committed changes. Closed by commit rG51e09e1d5aa4: [AMDGPU] Set the default globals address space to 1 (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D84345?vs=289235=306693#toc Repository: rG LLVM Github

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson added a comment. Herald added a subscriber: dexonsmith. ping @arsenm . I'd really like to land D70947 so that I can upstream further changes and that review is blocked on this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84345/new/ https://reviews.llvm.org/D84345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson updated this revision to Diff 289235. arichardson added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84345/new/ https://reviews.llvm.org/D84345 Files: clang/lib/Basic/Targets/AMDGPU.cpp

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson updated this revision to Diff 288316. arichardson added a comment. - fix failing tests after datalayout change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84345/new/ https://reviews.llvm.org/D84345 Files:

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); dylanmckay wrote: >

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

dylanmckay added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); dylanmckay wrote: >

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

dylanmckay added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); arichardson wrote: >

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL +

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

akhuang added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); arichardson wrote: > arsenm

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson marked an inline comment as done. arichardson added a subscriber: akhuang. arichardson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arsenm added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); I would expect datalayout

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson created this revision. arichardson added a reviewer: arsenm. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. Herald added projects: clang, LLVM. This will ensure that passes that add new global