[PATCH] D84375: [git-clang-format] Add --diffstat parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG191a395343b9: [git-clang-format] Add --diffstat parameter (authored by roligugus, committed by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

MyDeveloperDay added a comment. I just tested this an it seems to work $ git clang-format --diffstat clang/lib/Format/Format.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

MyDeveloperDay added a comment. In D84375#3065785 , @roligugus wrote: > @MyDeveloperDay Thanks for the follow-up! I've rebased on latest main. > > Out of curiosity, as I am trying to wrap my head around the llvm workflow: > Could I `arc land ...` myself

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus added a comment. @MyDeveloperDay Thanks for the follow-up! I've rebased on latest main. Out of curiosity, as I am trying to wrap my head around the llvm workflow: Could I `arc land ...` myself once you sign off with "ready to land" even if I don't have llvm commit rights? If so,

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus updated this revision to Diff 379892. roligugus added a comment. [git-clang-format] Rebase D84375 on latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84375/new/ https://reviews.llvm.org/D84375

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

MyDeveloperDay added a comment. @roligugus I can land this for you, please rebase the review then please add your name and email here so we can ensure you get the credit. https://llvm.org/docs/DeveloperPolicy.html#commit-messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus requested review of this revision. roligugus added a comment. @JakeMerdichAMD, @MyDeveloperDay Sorry to bother with a re-review. Did not know how to ask this. Jake accepted this patch last August and it has been sitting in "ready to land" since then. I was assuming that it'll

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

JakeMerdichAMD added reviewers: MyDeveloperDay, JakeMerdichAMD. JakeMerdichAMD added a comment. Reviving this since it looks perfectly fine to me (from my limited commit history in git-clang-format :P), is useful, and there's no good reason for it to be stalled. I'll wait a day or two to see

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

aheejin added a comment. This looks fine to me, but I haven't worked on this part of code myself, so probably others who have can provide better review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84375/new/ https://reviews.llvm.org/D84375

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus added a project: clang-format. roligugus marked an inline comment as done. roligugus added inline comments. Comment at: clang/tools/clang-format/git-clang-format:101 help='print a diff instead of applying the changes') + p.add_argument('--diffstat',

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus created this revision. roligugus added reviewers: klimek, aheejin. Herald added a project: clang. Herald added a subscriber: cfe-commits. [git-clang-format][PR46815] Add diffstat functionality Adding a --diffstat parameter to git-clang-format that essentially uses git diff --stat,