[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71d0a2b8a313: [DFSan][NewPM] Port DataFlowSanitizer to NewPM (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

morehouse accepted this revision. morehouse added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84707/new/ https://reviews.llvm.org/D84707 ___ cfe-commits mailing list

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassRegistry.def:92 MODULE_PASS("verify", VerifierPass()) +MODULE_PASS("dfsan", DataFlowSanitizerPass()) MODULE_PASS("asan-module", ModuleAddressSanitizerPass(/*CompileKernel=*/false, false, true, false))

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

morehouse added inline comments. Comment at: llvm/lib/Passes/PassRegistry.def:92 MODULE_PASS("verify", VerifierPass()) +MODULE_PASS("dfsan", DataFlowSanitizerPass()) MODULE_PASS("asan-module", ModuleAddressSanitizerPass(/*CompileKernel=*/false, false, true, false))

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/DataFlowSanitizer.h:11 + +#include "llvm/IR/Function.h" +#include "llvm/IR/Module.h" ychen wrote: > Is Function.h needed? Nope,

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks updated this revision to Diff 281109. aeubanks added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84707/new/ https://reviews.llvm.org/D84707 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM with two nits. Please wait one day or two in case other reviewers want to have a look. Comment at: llvm/include/llvm/Transforms/Instrumentation/DataFlowSanitizer.h:8

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, aaron.ballman, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84707 Files: clang/lib/CodeGen/BackendUtil.cpp