[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

ArcsinX added a comment. In D84912#2184144 , @kadircet wrote: > I think we should also cherry-pick this into release branch. I've filed > https://bugs.llvm.org/show_bug.cgi?id=46905 for cherry-picking please update > the bug > with the commit hash once y

[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

This revision was automatically updated to reflect the committed changes. Closed by commit rG05b173466142: [clangd] findNearbyIdentifier(): fix the word search in the token stream. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

ArcsinX added a comment. In D84912#2184147 , @kadircet wrote: > oh and also, how did you notice the discrepancy? was it a random encounter > while reading the code or did you notice a misbehaviour? Case was like this void f1(int [[paramValue]]){ }

[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

kadircet added a comment. oh and also, how did you notice the discrepancy? was it a random encounter while reading the code or did you notice a misbehaviour? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84912/new/ https://reviews.llvm.org/D84912

[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for catching this, LGTM! This might still end up traversing the whole file in non-existent cases, but I suppose that's an adventure for another day. I think we should also cherry-pi

[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Without this patch the word occurrence search always returns the