[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG673dbe1b5eef: [clang codegen] Use IR "align" attribute for static array arguments. (authored by efriedma). Repository: rG LLVM Github Monorepo CH

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84992/new/ https://reviews.llvm.org/D84992 ___

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2503 + llvm::Align Alignment = + CGM.getNaturalTypeAlignment(ETy).getAsAlign(); + AI->addAttrs(llvm::AttrBuilder().addAlignmentAttr(Alignment)); rj

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2503 + llvm::Align Alignment = + CGM.getNaturalTypeAlignment(ETy).getAsAlign(); + AI->addAttrs(llvm::AttrBuilder().addAlignmentAttr(Alignment)); Is

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

efriedma added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84992/new/ https://reviews.llvm.org/D84992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

efriedma created this revision. efriedma added a reviewer: rjmccall. Herald added a project: clang. efriedma requested review of this revision. Without the "align" attribute, marking the argument dereferenceable is basically useless. See also D80166 . Fixes http