[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

This revision was automatically updated to reflect the committed changes. Closed by commit rGe18c6ef6b41a: [clang] improve diagnostics for misaligned and large atomics (authored by tschuett, committed by jfb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett added a comment. I would appreciate it, if somebody could commit this patch on my behalf. Thorsten Schuett schu...@gmail.com Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___ cfe-co

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett updated this revision to Diff 282637. tschuett added a comment. added missing "alignment" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/Diagnost

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett added a comment. I wanted to save space. I know that the alignment is missing there, but the line is already too long. I have no rights to commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

jfb accepted this revision. jfb added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/atomics-sema-alignment.c:43 + Foo bar; + __atomic_load(foo, &bar, __ATOMIC_RELAXED); // expected-warning {{misaligned atomic operation may inc

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett updated this revision to Diff 282485. tschuett added a comment. add/updated test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticGroups.

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett added a comment. introduced in https://reviews.llvm.org/D45319 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

xbolva00 added a comment. Thanks. Can you add some test cases? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett updated this revision to Diff 282483. tschuett added a comment. Replaced (...) by ; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticGrou

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:274 + "misaligned atomic operation may incur " + "significant performance penalty " + "(the expected (%0 bytes) exceeds the actual alignment (%1 bytes)">, Use ; ra

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett created this revision. tschuett added a reviewer: rsmith. Herald added a reviewer: jfb. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. tschuett requested review of this revision. Herald added a subscriber: dexonsmith. "Listing the alignment and access size (==