[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu added a comment. In D85176#2572661 , @saugustine wrote: > This commit introduced an unused variable warning when built without asserts. > (CoverageMappingGen.cpp:984) I have fixed it with rG4544a63b7705 >

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

saugustine added a comment. This commit introduced an unused variable warning when built without asserts. (CoverageMappingGen.cpp:984) I have fixed it with rG4544a63b7705 . Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu added a comment. Landed at https://github.com/llvm/llvm-project/commit/d83511dd26ca8d0dd5be6302ad7b55de05cedab2 (forgot to add the differential revision line). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/new/ https://reviews.llvm

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

vsk accepted this revision. vsk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/new/ https://reviews.llvm.org/D85176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu added inline comments. Comment at: clang/test/CoverageMapping/if.cpp:10 +void foo() {// CHECK-NEXT: Gap,File 0, [[@LINE+1]]:21 -> [[@LINE+1]]:22 = #2 if (int j = true ? nop() // CHECK-NEXT: [[@LINE]]:22 -> [[@LINE]]:27 = #2

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu updated this revision to Diff 324710. zequanwu marked 2 inline comments as done. zequanwu added a comment. - Added regression test. - Assert `getIncludeOrExpansionLoc(AfterLoc)` is valid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

vsk added a comment. Could you check in the reproducer program (`void p`) as a regression test? Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:995 + +AfterLoc = getPreciseTokenLocEnd(getIncludeOrExpansionLoc(AfterLoc)); +assert(AfterLoc.isValid()); ---