[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

aeubanks added a comment. In D85384#2226866 , @craig.topper wrote: > In D85384#2226842 , @aeubanks wrote: > >> This doesn't work with -mtune=generic >> (https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html), can

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added a comment. In D85384#2226842 , @aeubanks wrote: > This doesn't work with -mtune=generic > (https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html), can gcc compatibility > be added? > > (https://crbug.com/1119448) > > $ cat /tmp/a.c >

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

aeubanks added a comment. This doesn't work with -mtune=generic (https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html), can gcc compatibility be added? (https://crbug.com/1119448) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85384/new/

Re: [PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

This would be because at that point the default cpu was that and it probably had something to do with fallbacks. At this point it can be changed I imagine to whatever makes sense. On Wed, Aug 19, 2020, 1:12 AM Craig Topper via Phabricator < revi...@reviews.llvm.org> wrote: > craig.topper added

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added a comment. In D85384#2225459 , @echristo wrote: > This would be because at that point the default cpu was that and it > probably had something to do with fallbacks. > > At this point it can be changed I imagine to whatever makes sense.

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added a subscriber: ddunbar. craig.topper added a comment. In D85384#2225434 , @phosek wrote: > This seems to have broken our Mac builders with the following error: > > -- Testing: 25226 tests, 24 workers -- > Testing: 0.. 10.. 20. >

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

phosek added a comment. This seems to have broken our Mac builders with the following error: -- Testing: 25226 tests, 24 workers -- Testing: 0.. 10.. 20. FAIL: Clang :: Frontend/ast-main.c (6834 of 25226) TEST 'Clang :: Frontend/ast-main.c' FAILED

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cbceb74bb56: [X86] Add basic support for -mtune command line option in clang (authored by craig.topper). Herald added a project: clang. Changed prior to commit:

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added inline comments. Comment at: clang/test/Misc/target-invalid-cpu-note.c:49 + +// RUN: not %clang_cc1 -triple x86_64--- -tune-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix TUNE_X86_64 +// TUNE_X86_64: error: unknown target CPU 'not-a-cpu'

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one minor comment Comment at: clang/test/Misc/target-invalid-cpu-note.c:49 + +// RUN: not %clang_cc1 -triple x86_64--- -tune-cpu not-a-cpu -fsyntax-only %s

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1752 StringRef TargetCPU = getTarget().getTargetOpts().CPU; + StringRef TuneCPU = getTarget().getTargetOpts().TuneCPU; std::vector Features; erichkeane wrote: >

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1752 StringRef TargetCPU = getTarget().getTargetOpts().CPU; + StringRef TuneCPU = getTarget().getTargetOpts().TuneCPU; std::vector Features; craig.topper wrote: > erichkeane

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1752 StringRef TargetCPU = getTarget().getTargetOpts().CPU; + StringRef TuneCPU = getTarget().getTargetOpts().TuneCPU; std::vector Features; erichkeane wrote: > Does this

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

erichkeane added a comment. 1 comment, otherwise seems alright to me. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1752 StringRef TargetCPU = getTarget().getTargetOpts().CPU; + StringRef TuneCPU = getTarget().getTargetOpts().TuneCPU; std::vector Features;

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85384/new/ https://reviews.llvm.org/D85384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

craig.topper created this revision. craig.topper added reviewers: echristo, RKSimon, spatel, efriedma. Herald added a subscriber: dang. craig.topper requested review of this revision. Building on the backend support from D85165 . This parses the command line