eduucaldas updated this revision to Diff 284387.
eduucaldas marked 6 inline comments as done and 2 inline comments as done.
eduucaldas added a comment.
Answer comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85439/new/
eduucaldas added a comment.
There are some refinements to do, to generate a complete syntax tree. Namely
tag decltype-name-specifier and simple-template-specifier children with roles,
to allow for accessors.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:838-842
+
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
Comment at: clang/include/clang/AST/NestedNameSpecifier.h:20
#include "clang/Basic/SourceLocation.h"
+#include "llvm/ADT//DenseMapInfo.h"
#include "llvm/ADT/FoldingSet.h"
eduucaldas marked 2 inline comments as done.
eduucaldas added a comment.
Now NNS are based on inheritance!
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:849-850
+ const auto TL = NNSLoc.getTypeLoc().castAs();
+ if
eduucaldas updated this revision to Diff 284285.
eduucaldas added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85439/new/
https://reviews.llvm.org/D85439
Files:
clang/include/clang/AST/NestedNameSpecifier.h
eduucaldas updated this revision to Diff 284284.
eduucaldas added a comment.
Move to using inheritance
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85439/new/
https://reviews.llvm.org/D85439
Files:
clang/include/clang/AST/NestedNameSpecifier.h
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:227-254
+namespace llvm {
+template <> struct DenseMapInfo {
+ using FirstInfo = DenseMapInfo;
+ using
eduucaldas added a reviewer: gribozavr2.
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:227-254
+namespace llvm {
+template <> struct DenseMapInfo {
+ using FirstInfo = DenseMapInfo;
+ using SecondInfo = DenseMapInfo;
+
+ static inline
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
eduucaldas requested review of this revision.
We want NestedNameSpecifier syntax nodes to be generally supported, not
only for `DeclRefExpr` and `DependentScopedDeclRefExpr`.
To achieve this
