This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rGfb04d7b4a698: [CUDA][HIP] Do not externalize implicit
constant static variable (authored by yaxunl).
Herald added a project: clang.
Changed prior to commit:
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:11196
return !getLangOpts().GPURelocatableDeviceCode &&
- (D->hasAttr() || D->hasAttr()) &&
+ (D->hasAttr() ||
+ (D->hasAttr() &&
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/AST/ASTContext.cpp:11196
return !getLangOpts().GPURelocatableDeviceCode &&
- (D->hasAttr() || D->hasAttr()) &&
+ (D->hasAttr() ||
+
yaxunl created this revision.
yaxunl added a reviewer: tra.
yaxunl requested review of this revision.
https://reviews.llvm.org/D85686
Files:
clang/include/clang/AST/ASTContext.h
clang/lib/AST/ASTContext.cpp
clang/lib/Sema/SemaExpr.cpp
clang/test/CodeGenCUDA/static-device-var-no-rdc.cu
