[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8c92b54d74c: [SyntaxTree] Use Annotations based tests for expressions (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286259. eduucaldas added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.cpp:199 + auto AnnotatedRanges = AnnotatedCode.ranges(); + assert(AnnotatedRanges.size() == TreeDumps.size()); + for (auto i = 0ul; i < AnnotatedRanges.size(); i++) {

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286258. eduucaldas added a comment. Fail on non-matching number of tree dumps and annotations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files:

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286251. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:477 struct X { friend X operator+(const X&, const X&); }; A test for this part was created below Comment at:

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286248. eduucaldas marked 7 inline comments as done. eduucaldas added a comment. Answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files:

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Very nice improvement to tests! Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:784 + +TEST_P(SyntaxTreeTest, QualifiedId_ComplexDeclaration) { + if

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.cpp:197 + + bool failed = false; + auto AnnotatedRanges = AnnotatedCode.ranges(); Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.cpp:199 +

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 285632. eduucaldas added a comment. Add annotations to the last missing tests in expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files:

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 285629. eduucaldas added a comment. Move added Declaration tests to an appropriate place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files:

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 285613. eduucaldas added a comment. Previous diff had only the last commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files:

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. In this process we also create some other tests, in order to not lose coverage when focusing on the annotated code. Repository: rG LLVM Github