[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. We forgot to update the signature and definition of `OptTable::findByPrefix`: https://github.com/llvm/llvm-project/blob/257b29715bb27b7d9f6c3c40c481b6a4af0b37e5/llvm/include/llvm/Option/OptTable.h#L154-L155. That's required after updating the definition of

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG257b29715bb2: [flang][driver] Add the new flang compiler and frontend drivers (authored by CarolineConcatto). Changed prior to commit:

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

richard.barton.arm accepted this revision. richard.barton.arm added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089 ___ cfe-commits mailing list

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 291068. awarzynski marked 2 inline comments as done. awarzynski added a comment. Address final comments I also took the liberty and made the following changes in CMake scripts: - replaced add_library wiht add_flang_library - replaced add_executable with

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

richard.barton.arm accepted this revision. richard.barton.arm added a comment. This revision is now accepted and ready to land. This LGTM. I think all the previous comments from other reviewers and me have been dealt with so I am happy to accept this revision based on the reviews so far. I

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 290435. awarzynski added a comment. Add missing update in lit.cfg.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089 Files: clang/include/clang/Driver/Driver.h

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. In D86089#2256139 , @richard.barton.arm wrote: > Another random thought that just came to me: what does the new driver do when > you invoke it with no input files or options? I could imagine a few sensible > outcomes (error:

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 290337. awarzynski marked 2 inline comments as done. awarzynski added a comment. - Adddressed comments from @richard.barton.arm - Added FC1Option to ClangFlags (and made other related changes) - Added missing code to check return codes from subcommands

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

richard.barton.arm added a comment. Another random thought that just came to me: what does the new driver do when you invoke it with no input files or options? I could imagine a few sensible outcomes (error: no input (clang and gcc/gfortran behaviour), print version and exit, print help and

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

richard.barton.arm requested changes to this revision. richard.barton.arm added a comment. This revision now requires changes to proceed. Requesting changes mostly because of the exit status issue on the Driver tests. A few general questions as well: 1. Why not implement `-###` as part of this

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 289111. awarzynski marked an inline comment as done. awarzynski added a comment. Update README.md with instructions for building `flang-new` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

sameeranjoshi accepted this revision. sameeranjoshi added a comment. Thank you for changes. I was able to build successfully out-of-tree. Please update the `README.md` with the necessary changes. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski commandeered this revision. awarzynski added a reviewer: CarolineConcatto. awarzynski added a comment. @sameeranjoshi Thanks for testing out-of-tree builds. We were missing some minor changes in CMake. I have now uploaded these. Out-of-tree will require `-DCLANG_DIR` when configuring

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 288424. awarzynski added a comment. Added support for out-of-tree builds. It requires -DCLANG_DIR=/lib/cmake/clang when configuring CMake. That's on top of LLVM_DIR and MLIR_DIR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. @andwar is my Phabricator alter-ego. Apologies for the confusion - I had my Arcanist misconfigured. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

andwar updated this revision to Diff 288018. andwar added a comment. - Canonicalised FLANG_BUILD_NEW_DRIVER in flang/test/CMakeLists.txt and updated the LIT config scripts accordingly - Implemented proper handling of `-emit-obj` (via diagnostics) in CompilerInvocation.cpp - Removed members from

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. @CarolineConcatto - thank you for working on this! @all, thank you for your reviews, this is much appreciated! While Carol is away, I'll try my best to address all the outstanding comments. I will also update the patch accordingly. I've identified a few small issues

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

SouraVX added inline comments. Comment at: flang/tools/flang-driver/fc1_main.cpp:1 +//===-- fc1_main.cpp - Flang FC1 Compiler Frontend ===// +// This file-name seems odd considering LLVM style. How about just `Flang.cpp` or

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

CarolineConcatto marked 17 inline comments as done. CarolineConcatto added a comment. Hey Folks, Fist of all, thank you very much for your review. I have answered some questions and update some of the requests. There are some that I did not had time to go inside yet. I have the week of 24th

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

CarolineConcatto updated this revision to Diff 287270. CarolineConcatto added a comment. Address review comments Replace namespace flang for Fortran::frontend and fix style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

sameeranjoshi requested changes to this revision. sameeranjoshi added a comment. Thanks for working on it. A few review comments/questions on changes in `flang` part from the patch. Comment at: flang/include/flang/Frontend/CompilerInstance.h:93 + + static

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

richard.barton.arm added inline comments. Comment at: flang/test/lit.cfg.py:40 +# exclude the tests for flang_new driver while there are two drivers +if config.include_flang_new_driver_test == "OFF": + config.excludes = ['Inputs', 'CMakeLists.txt', 'README.txt', 'LICENSE.txt',

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

sameeranjoshi added a comment. Thanks for the work. A couple of comments on `clang/` related changes: An `out-of-tree` build with this patch fails for me: Here's what I did: I initially used `ENABLE_PROJECTS="clang;mlir"` to build `llvm-project`, I didn't build `flang` during this run. Then I

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

richard.barton.arm requested changes to this revision. richard.barton.arm added a comment. A few specific comments to address here as well as the pre-commit linting ones. Comment at: clang/lib/Driver/Driver.cpp:1584 void Driver::PrintVersion(const Compilation , raw_ostream )

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

tskeith requested changes to this revision. tskeith added inline comments. This revision now requires changes to proceed. Comment at: flang/include/flang/Frontend/CompilerInstance.h:11 + +#include "flang/Frontend/CompilerInvocation.h" + Why is this called