[PATCH] D86130: [AST] Fix a crash on mangling a binding decl from a DeclRefExpr.

2020-08-19 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b797eb5b4db: [AST] Fix a crash on mangling a binding decl from a DeclRefExpr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86130: [AST] Fix a crash on mangling a binding decl from a DeclRefExpr.

2020-08-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D86130#2224757 , @rsmith wrote: > Here's a testcase that produces a name with external linkage: > > struct X { int i, j; }; > auto [a,b] = X{1,2}; > template void f(decltype(a + T())) {} > template void f(int); > > We sho

[PATCH] D86130: [AST] Fix a crash on mangling a binding decl from a DeclRefExpr.

2020-08-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 286488. hokein added a comment. add one more test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86130/new/ https://reviews.llvm.org/D86130 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/CodeGenCXX/mangl

[PATCH] D86130: [AST] Fix a crash on mangling a binding decl from a DeclRefExpr.

2020-08-18 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Here's a testcase that produces a name with external linkage: struct X { int i, j; }; auto [a,b] = X{1,2}; template void f(decltype(a + T())) {} template void f(int); We should make su

[PATCH] D86130: [AST] Fix a crash on mangling a binding decl from a DeclRefExpr.

2020-08-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: rsmith. Herald added a project: clang. hokein requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86130 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/CodeGenCXX/mangle.cpp Index: clang