[PATCH] D86187: [X86] Add support 'tune' in target attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG724f570ad255: [X86] Add support tune in target attribute (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86187: [X86] Add support 'tune' in target attribute

efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/ https://reviews.llvm.org/D86187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86187: [X86] Add support 'tune' in target attribute

craig.topper updated this revision to Diff 286661. craig.topper added a comment. Refine the diagnostic message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/ https://reviews.llvm.org/D86187 Files: clang/include/clang/AST/Attr.h clang/include/clang/Basic/Attr.td

[PATCH] D86187: [X86] Add support 'tune' in target attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attr.h:346 + Tune == Other.Tune && + BranchProtection == Other.BranchProtection && + Features == Other.Features; craig.topper wrote: > Was it a bug that

[PATCH] D86187: [X86] Add support 'tune' in target attribute

efriedma added inline comments. Comment at: clang/test/Sema/attr-target.c:26 +//expected-warning@+1 {{unsupported tune 'hiss' in the 'target' attribute string; 'target' attribute ignored}} +int __attribute__((target("tune=hiss,tune=woof"))) apple_tree() { return 4; } +

[PATCH] D86187: [X86] Add support 'tune' in target attribute

craig.topper added inline comments. Comment at: clang/include/clang/AST/Attr.h:346 + Tune == Other.Tune && + BranchProtection == Other.BranchProtection && + Features == Other.Features; Was it a bug that BranchProtection wasn't in

[PATCH] D86187: [X86] Add support 'tune' in target attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. In D86187#2226621 , @craig.topper wrote: > Add a note to AttrDocs.td Thanks for the docs update, continues to LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/

[PATCH] D86187: [X86] Add support 'tune' in target attribute

craig.topper updated this revision to Diff 286602. craig.topper added a comment. Add a note to AttrDocs.td CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/ https://reviews.llvm.org/D86187 Files: clang/include/clang/AST/Attr.h clang/include/clang/Basic/Attr.td

[PATCH] D86187: [X86] Add support 'tune' in target attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, but perhaps there should be some changes in AttrDocs.td to document the new support? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/ https://reviews.llvm.org/D86187

[PATCH] D86187: [X86] Add support 'tune' in target attribute

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. CFE changes look right to me. Please give the rest of the reviews a little while to take a look though CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/

[PATCH] D86187: [X86] Add support 'tune' in target attribute

craig.topper created this revision. craig.topper added reviewers: echristo, erichkeane, spatel, RKSimon. Herald added a reviewer: aaron.ballman. craig.topper requested review of this revision. This adds parsing and codegen support for tune in target attribute. I've implemented this so that arch