[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy abandoned this revision. hoy added a comment. Abandoning this diff which has been broken into four other diffs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/ https://reviews.llvm.org/D86193

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy added a comment. @davidxl I'm wondering if it is a good time for you to start reviewing the patches. Please let me know if you need more time. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/ https://reviews.llvm.org/D86193

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

wmi added a comment. Herald added a subscriber: ecnelises. The patches split from the main one look good to me. Please see if David has further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/ https://reviews.llvm.org/D86193

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy added a comment. In D86193#2240596 , @wmi wrote: > In D86193#2240502 , @hoy wrote: > >> In D86193#2240353 , @wmi wrote: >> There are some optimizations such as

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

wmi added a comment. In D86193#2240502 , @hoy wrote: > In D86193#2240353 , @wmi wrote: > >>> There are some optimizations such as if-convert, tail call elimination, >>> that were initially blocked by the pseudo

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy added a comment. In D86193#2240353 , @wmi wrote: >> There are some optimizations such as if-convert, tail call elimination, that >> were initially blocked by the pseudo probe intrinsic but is now unblocked by >> fixes included in this change. With

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

wmi added a comment. > There are some optimizations such as if-convert, tail call elimination, that > were initially blocked by the pseudo probe intrinsic but is now unblocked by > fixes included in this change. With the current change we do not see perf > degradation out of SPEC and one of

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy added a comment. In D86193#2232609 , @wmi wrote: > Thanks for the patch! A few questions: > >> probe blocks some CFG transformations that can mess up profile correlation. > > Can you enumerate some CFG transformations which be blocked? Is it possible

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

wmi added a comment. Thanks for the patch! A few questions: > probe blocks some CFG transformations that can mess up profile correlation. Can you enumerate some CFG transformations which be blocked? Is it possible that some CFG transformations being blocked are actually beneficial for later

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy added a comment. In D86193#2227129 , @davidxl wrote: > A heads up -- I won't be able to review patch until mid Sept. Hope this is > fine. Thanks for the heads-up. That's fine. We can wait for your input. Repository: rG LLVM Github Monorepo

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy updated this revision to Diff 286664. hoy edited the summary of this revision. hoy added a comment. Updating D86193 : [CSSPGO] Pseudo probe instrumentation for basic blocks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

davidxl added a comment. A heads up -- I won't be able to review patch until mid Sept. Hope this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/ https://reviews.llvm.org/D86193 ___

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks

hoy updated this revision to Diff 286476. hoy added a comment. Updating D86193 : [CSSPGO] Pseudo probe instrumentation for basic blocks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks

hoy created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, laytonio, asbirlea, hiraditya, mgorny. Herald added projects: clang, LLVM. hoy requested review of this revision. Herald added a subscriber: jdoerfert. Repository: rG LLVM Github Monorepo